Skip to content

Commit

Permalink
build(workflows): version is hard coded in gradle
Browse files Browse the repository at this point in the history
  • Loading branch information
GiugAles committed Jan 25, 2024
1 parent 879752f commit 5ac2388
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/containerize.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ jobs:
YGGDRASIL_VERSION: "${{ needs.set-vars.outputs.VERSION }}"
ports:
- "8899:8080"
env:
YGGDRASIL_VERSION: "${{ needs.set-vars.outputs.VERSION }}"
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -68,15 +66,15 @@ jobs:
build/reports
if-no-files-found: error
- name: Make structure for app
run: cp build/libs/yggdrasil-${{ env.YGGDRASIL_VERSION }}-SNAPSHOT-all.jar .
run: cp build/libs/yggdrasil-0.0.0-SNAPSHOT-all.jar .
- name: Upload app to GitHub
uses: actions/upload-artifact@v3
if: always()
with:
name: app
path: |
conf/docker_disk_config.json
yggdrasil-${{ env.YGGDRASIL_VERSION }}-SNAPSHOT-all.jar
yggdrasil-0.0.0-SNAPSHOT-all.jar
if-no-files-found: error

containerize:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ FROM eclipse-temurin:21

ARG YGGDRASIL_VERSION

# Entrypoint requires having it as ENV
# Here as precaution but actually not used when naming the jar
ENV YGGDRASIL_VERSION ${YGGDRASIL_VERSION}

# https://stackoverflow.com/a/793867
RUN mkdir -p /opt/
ADD opt/app/ /opt/app/
WORKDIR /opt/app/

ENTRYPOINT java -jar /opt/app/yggdrasil-${YGGDRASIL_VERSION}-SNAPSHOT-all.jar
ENTRYPOINT java -jar /opt/app/yggdrasil-0.0.0-SNAPSHOT-all.jar

0 comments on commit 5ac2388

Please sign in to comment.