Skip to content

Commit

Permalink
checking how to define paths consistently
Browse files Browse the repository at this point in the history
  • Loading branch information
GiugAles committed Jan 23, 2024
1 parent 3affb27 commit ae760f5
Showing 1 changed file with 16 additions and 18 deletions.
34 changes: 16 additions & 18 deletions .github/workflows/containerized.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,17 @@ jobs:
if: always()
with:
name: app
path: "build/libs/yggdrasil-${{ env.YGGDRASIL_VERSION }}-SNAPSHOT-all.jar"
if-no-files-found: error
- name: Upload conf to GitHub
uses: actions/upload-artifact@v3
if: always()
with:
name: conf
path: conf/docker_disk_config.json
path: |
conf/docker_disk_config.json
build/libs/yggdrasil-${{ env.YGGDRASIL_VERSION }}-SNAPSHOT-all.jar
if-no-files-found: error
# - name: Upload conf to GitHub
# uses: actions/upload-artifact@v3
# if: always()
# with:
# name: conf
# path: conf/docker_disk_config.json
# if-no-files-found: error

build-container:
needs: build-app
Expand All @@ -77,29 +79,25 @@ jobs:
run:
shell: bash
steps:
-
name: Checkout
- name: Checkout
uses: actions/checkout@v4
-
name: Login to Docker Hub
- name: Login to Docker Hub
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_HUB_USER }}
password: ${{ secrets.DOCKER_HUB_TOKEN }}
-
name: Set up Docker Buildx
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
-
# WARNING: https://stackoverflow.com/a/57877438 is suggesting to use '@master'
# however due to change from "master" to "main", "master" is outdated
uses: actions/download-artifact@v3
- uses: actions/download-artifact@v3
id: download
with:
# Omitting name to download all artifacts
# Skipping '/' is on purpose
path: opt/app
-
name: Build and push
- name: Build and push
uses: docker/build-push-action@v5
with:
context: .
Expand Down

0 comments on commit ae760f5

Please sign in to comment.