-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/devcontainer stack compose #29
Open
GiugAles
wants to merge
4
commits into
main
Choose a base branch
from
feature/devcontainer-stack-compose
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5668819
build(docker): multi stage build removes JDK requirement on host
GiugAles 52ec423
build(docker): mount and cache prevents loss of changes
GiugAles a97b168
build(docker): multi stage build makes ignoring files unnecessary
GiugAles 1e33e4c
build(docker): mergeable compose files reduce number of files to main…
GiugAles File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"name": "[Optional] Your project name here", | ||
"dockerComposeFile": ["../docker-compose.yml", "../docker-compose-dev.yml"], | ||
"service": "yggdrasil", | ||
"workspaceFolder": "/opt/app/", | ||
"shutdownAction": "stopCompose" | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# Yggdrasil build configuration | ||
YGGDRASIL_VERSION=0.0.0 | ||
# Build environment preparation | ||
LANG=C.UTF-8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,3 @@ | ||||||||||||
# Set the default behavior, in case people don't have core.autocrlf set. | ||||||||||||
* text=auto | ||||||||||||
gradlew binary | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
FROM eclipse-temurin:21 | ||
FROM eclipse-temurin:21 as builder | ||
|
||
ADD . /opt/app/ | ||
|
||
# Yggdrasil build configuration | ||
ENV YGGDRASIL_VERSION 0.0.0 | ||
WORKDIR /opt/app/ | ||
RUN ./gradlew | ||
|
||
FROM eclipse-temurin:21 | ||
|
||
# Build environment preparation | ||
ENV LANG C.UTF-8 | ||
RUN apt update && apt install -y \ | ||
git \ | ||
&& rm -rf /var/cache/apt/archives /var/lib/apt/lists/* | ||
|
||
# Copy the jar | ||
RUN mkdir /opt/app | ||
COPY build/libs/yggdrasil-${YGGDRASIL_VERSION}-SNAPSHOT-all.jar /opt/app | ||
# Copy the configuration | ||
RUN mkdir /opt/app/conf | ||
COPY conf/docker_disk_config.json /opt/app/conf/config.json | ||
ARG YGGDRASIL_VERSION | ||
|
||
# The default http port | ||
EXPOSE 8080 | ||
# The port for interacting with CArtAgO | ||
EXPOSE 8088 | ||
# https://stackoverflow.com/a/793867 | ||
RUN mkdir -p /opt/app/conf | ||
COPY --from=builder /opt/app/build/libs/yggdrasil-${YGGDRASIL_VERSION}-SNAPSHOT-all.jar /opt/app/libs/ | ||
COPY --from=builder /opt/app/conf/docker_disk_config.json /opt/app/conf/config.json | ||
|
||
ENTRYPOINT java -jar /opt/app/yggdrasil-${YGGDRASIL_VERSION}-SNAPSHOT-all.jar | ||
ENTRYPOINT java -jar /opt/app/libs/yggdrasil-${YGGDRASIL_VERSION}-SNAPSHOT-all.jar |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
version: '3.9' | ||
# This file adds extensions needed for development and needs to be merged with docker-compose.yml | ||
# See https://docs.docker.com/compose/multiple-compose-files/merge/ | ||
|
||
services: | ||
yggdrasil: | ||
# overwrite entrypoint of productive image | ||
entrypoint: ["tail", "-F", "anything"] | ||
container_name: yggdrasil-dev | ||
# Sync changes with host | ||
volumes: | ||
- .:/opt/app/:cached # does already exist but https://stackoverflow.com/a/39647631 | ||
# restarting causes problems when using vscode's "Reopne in Container" | ||
restart: "no" | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.