Fix bugs from a distant past #48

cake-lier · 2024-06-20T16:12:12Z

This PR contains

A bug fix for which a feedback parameter was not added to the list of parameters when invoking a CArtAgO operation without any other parameter. This was due to a missing check in the code which defaulted to not adding anything in case of missing parameters (even if a feedback one was present).
A bug fix for which using an empty HttpConfig object in the HypermediaArtifact made the URI of the artifact always begin with "http://localhost:8080" instead of the correct URI. This was due to not using the right configuration object inherited from the Vert.X verticle on which the class was being created.

…her param was present

…tifact semantic description construction

andreiciortea

Great, thanks @cake-lier !

cake-lier added 2 commits June 20, 2024 18:05

fix: fix bug where feedback param was not added to operation if no ot…

89b4b23

…her param was present

fix: fix bug where external configuration was ignored in HypermediaAr…

e0c75bf

…tifact semantic description construction

cake-lier added the bug Something isn't working label Jun 20, 2024

cake-lier requested a review from andreiciortea June 20, 2024 16:12

cake-lier self-assigned this Jun 20, 2024

andreiciortea approved these changes Jun 21, 2024

View reviewed changes

andreiciortea merged commit 717f850 into main Jun 21, 2024
1 check passed

andreiciortea deleted the fix/feedback-and-conf branch June 21, 2024 03:38

Provide feedback