Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(websub) add content types #54

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

danaivach
Copy link
Collaborator

@danaivach danaivach requested a review from KaiTries August 29, 2024 10:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.30%. Comparing base (27ebe3e) to head (efafe63).
Report is 375 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #54      +/-   ##
============================================
+ Coverage     75.27%   77.30%   +2.03%     
- Complexity      391      525     +134     
============================================
  Files            35       47      +12     
  Lines          2208     3208    +1000     
  Branches         75      132      +57     
============================================
+ Hits           1662     2480     +818     
- Misses          498      647     +149     
- Partials         48       81      +33     
Flag Coverage Δ
unittests 77.30% <100.00%> (+2.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KaiTries KaiTries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@danaivach danaivach merged commit d1ae75d into main Aug 30, 2024
1 check passed
@danaivach danaivach deleted the feat/websub-content-types branch August 30, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add content type in WebSub notifications
3 participants