Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pip install InternLM #8

Closed
wants to merge 2 commits into from

Conversation

sallyjunjun
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

support pip install InternLM.

Modification

add setup.py and tensorboard requirement.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sunpengsdu
Copy link
Contributor

也补充下相关的文档?

@sallyjunjun
Copy link
Collaborator Author

也补充下相关的文档?

已补充

@sallyjunjun sallyjunjun force-pushed the develop-evo branch 13 times, most recently from 82fd0d8 to f47ecdc Compare January 24, 2024 02:39
- name: Build and upload package
run: |
source /mnt/petrelfs/share_data/llm_env/env/llm-flash2.0
srun -p ${SLURM_PARTITION} --kill-on-bad-exit=1 --job-name=internlm-ut-${GITHUB_RUN_ID}-${GITHUB_JOB} -N 1 -n 1 --gres=gpu:8 python setup.py sdist bdist_wheel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci资源紧缺,这里申请一个GPU就好了,不需要申请8个

@sallyjunjun sallyjunjun force-pushed the develop-evo branch 10 times, most recently from 924b1eb to 351c6c2 Compare January 25, 2024 02:20
@sallyjunjun sallyjunjun force-pushed the develop-evo branch 4 times, most recently from 2cf673a to 77b959f Compare January 25, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants