Updated Twitter Old twitter Logo #668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Consider placing the image in the src/assets/imgs directory rather than downloading it from the data source every time the page is loaded, thereby avoiding additional dependency and latency. |
|
Okay on it |
|
@mohamedawnallah now its okay? |
|
LGTM! Thanks |
@MAVRICK-1 @mohamedawnallah don't you think direct use of image can affect the website for long term perspective.... |
|
@RickDeb2004 I don't think adding |
|
closed by #669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated Old twitter
fixed the issue of #667
Screenshots (if appropriate):
Types of changes
IHR TWEETS Logo updated
Checklist:
@romain-fontugne @mohamedawnallah review