Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: teodanciu <teodora.danciu@tweag.io>
  • Loading branch information
lehins and teodanciu authored Dec 20, 2024
1 parent 5a3949b commit 9427fcd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions libs/cardano-ledger-core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
* `SafeHash`, `SafeToHash`, `HashAnnotated`, `castSafeHash` and `extractHash`.
* `KeyRoleVRF`, `VRFVerKeyHash`, `toVRFVerKeyHash`, `fromVRFVerKeyHash`
* `GenDelegPair` and `GenDelegs`
* Re-export `KeyRole` from `Cardano.Ledger.Hashes`:
* Re-export some of the new additions to `Cardano.Ledger.Hashes` from `Cardano.Ledger.Core.
* Re-export `KeyRole` from `Cardano.Ledger.Hashes`.
* Re-export some of the new additions to `Cardano.Ledger.Hashes` from `Cardano.Ledger.Core`.
* Remove `GenesisCredential` as unused.
* Remove `HASH`, `ADDRHASH` and `DSIGN` type families out of `Crypto` type class and turn
them into type synonyms for the exact algorithms previously being used in
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
{-# OPTIONS_HADDOCK not-home #-}

-- Contents of this module will be moved to `Cardano.Protocol.Crypto` at some point later
-- whenever we are ready to remove derpecations
-- whenever we are ready to remove deprecations
module Cardano.Ledger.Crypto.Internal (
Crypto (..),
StandardCrypto,
Expand Down
2 changes: 1 addition & 1 deletion libs/cardano-ledger-core/src/Cardano/Ledger/Hashes.hs
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ newtype GenDelegs = GenDelegs
-- original bytes is to use the type 'MemoBytes', although there are a few types that
-- store their original bytes in other ways. In order to encourage the use of newtype over
-- 'Cardano.Ledger.MemoBytes.MemoBytes' newtype defined as a 'MemoBytes', which would get
-- the functionality of retaining bytes and derviging of 'SafeToHash' instance for free.
-- the functionality of retaining bytes and deriving of 'SafeToHash' instance for free.

-- | A 'SafeHash' is a hash of something that is safe to hash. Such types store their own
-- serialisation bytes. The prime example is @('MemoBytes' t)@, but other examples are
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import GHC.Generics (Generic)
import NoThunks.Class (NoThunks (..))
import Quiet

-- | Cryptographic saigning algorithm used on Cardano blockchain.
-- | Cryptographic signing algorithm used on Cardano blockchain.
type DSIGN = DSIGN.Ed25519DSIGN

-- | The role of a key.
Expand Down

0 comments on commit 9427fcd

Please sign in to comment.