Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: teodanciu <teodora.danciu@tweag.io>
  • Loading branch information
lehins and teodanciu authored Dec 20, 2024
1 parent 9aedc22 commit f8410db
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion eras/allegra/impl/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## 1.7.0.0

* Remove deprecated `AuxiliaryData` type synnym
* Remove deprecated `AuxiliaryData` type synonym
* Deprecate `Allegra` type synonym
* Remove crypto parametrization from `AllegraEra`

Expand Down
12 changes: 6 additions & 6 deletions libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/Same.hs
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ sameShelleyTxBody proof (ShelleyTxBody i1 o1 c1 (Withdrawals w1) f1 s1 pu1 d1) (
, ("Fee", eqVia pcCoin f1 f2)
, ("TimeToLive", eqVia pcSlotNo s1 s2)
, ("PPupdate", eqVia (\_ -> ppString "Update") pu1 pu2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
]

sameAllegraTxBody ::
Expand All @@ -420,7 +420,7 @@ sameAllegraTxBody proof (AllegraTxBody i1 o1 c1 (Withdrawals w1) f1 v1 pu1 d1) (
, ("Fee", eqVia pcCoin f1 f2)
, ("ValidityInterval", eqVia ppValidityInterval v1 v2)
, ("PPupdate", eqVia (\_ -> ppString "Update") pu1 pu2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
]

sameMaryTxBody ::
Expand All @@ -437,7 +437,7 @@ sameMaryTxBody proof (MaryTxBody i1 o1 c1 (Withdrawals w1) f1 v1 pu1 d1 m1) (Mar
, ("Fee", eqVia pcCoin f1 f2)
, ("ValidityInterval", eqVia ppValidityInterval v1 v2)
, ("PPupdate", eqVia (\_ -> ppString "Update") pu1 pu2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("Mint", eqVia multiAssetSummary m1 m2)
]

Expand All @@ -462,7 +462,7 @@ sameAlonzoTxBody
, ("ReqSignerHashes", eqVia (ppSet pcKeyHash) r1 r2)
, ("Mint", eqVia multiAssetSummary m1 m2)
, ("ScriptIntegrityHash", eqVia (ppStrictMaybe (trim . ppSafeHash)) s1 s2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("NetworkId", eqVia (ppStrictMaybe pcNetwork) n1 n2)
]

Expand Down Expand Up @@ -492,7 +492,7 @@ sameBabbageTxBody
, ("ReqSignerHashes", eqVia (ppSet pcKeyHash) r1 r2)
, ("Mint", eqVia multiAssetSummary m1 m2)
, ("ScriptIntegrityHash", eqVia (ppStrictMaybe (trim . ppSafeHash)) s1 s2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("NetworkId", eqVia (ppStrictMaybe pcNetwork) n1 n2)
]

Expand Down Expand Up @@ -521,7 +521,7 @@ sameConwayTxBody
, ("ReqSignerHashes", eqVia (ppSet pcKeyHash) r1 r2)
, ("Mint", eqVia multiAssetSummary m1 m2)
, ("ScriptIntegrityHash", eqVia (ppStrictMaybe (trim . ppSafeHash)) s1 s2)
, ("AuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("TxAuxDataHash", eqVia (ppStrictMaybe (\(TxAuxDataHash h) -> trim (ppSafeHash h))) d1 d2)
, ("NetworkId", eqVia (ppStrictMaybe pcNetwork) n1 n2)
,
( "VotingProcedures"
Expand Down

0 comments on commit f8410db

Please sign in to comment.