Backport release cardano-ledger-conway-1.17.4.0
#4814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egation invariant
Introduction of an internal variant allows us using it in the DELEG ledger rule where we have current delegation readily available
Previous semantics did not allow to withdraw rewards and deregister in the same transaction, because deregistration would effectively clear out delegation to a DRep, thus preventing withdrawals
This is how it was suppose to be implemented to begin with, however this fix no longer can be applied without a hradfork, so the follow up commit will take care of that.
We can no longer fix this issue without a hardfork. The danger of fixing it without a hardfork would be that discrepencies in the ledger state could lead to different nodes having different DRep delegations when we out of the bootstrap, if such bug to be manifested on mainnet. This commit ensures that the fix is applied during the hardfork out of the bootstrap phase.
|
Dammit. Opened a PR from a wrong branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #4813
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)