Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hash size proofs #4819

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Removed hash size proofs #4819

merged 1 commit into from
Jan 14, 2025

Conversation

Soupstraw
Copy link
Contributor

Description

closes #4794

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw requested a review from a team as a code owner January 7, 2025 10:48
@Soupstraw Soupstraw force-pushed the jj/txout-simplification branch from 734a987 to 05e3262 Compare January 7, 2025 10:49
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more cleanup is still needed

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/txout-simplification branch 7 times, most recently from ca9496b to f2a8447 Compare January 8, 2025 11:58
@Soupstraw Soupstraw requested a review from lehins January 8, 2025 12:13
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but more changes are needed

eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/TxOut.hs Outdated Show resolved Hide resolved
eras/babbage/impl/src/Cardano/Ledger/Babbage/TxOut.hs Outdated Show resolved Hide resolved
eras/babbage/impl/src/Cardano/Ledger/Babbage/TxOut.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/txout-simplification branch from 40e3ea0 to 91c6a23 Compare January 9, 2025 10:32
@Soupstraw Soupstraw requested a review from lehins January 9, 2025 10:43
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
Just needs a fourmolu and a rebase on master that contains a hie fix on CI

Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
@Soupstraw Soupstraw force-pushed the jj/txout-simplification branch from 91c6a23 to 73afa30 Compare January 14, 2025 11:52
@Soupstraw Soupstraw enabled auto-merge (rebase) January 14, 2025 11:53
@Soupstraw Soupstraw merged commit 7683b73 into master Jan 14, 2025
487 of 586 checks passed
@Soupstraw Soupstraw deleted the jj/txout-simplification branch January 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify TxOut definition
2 participants