Improve error handling in constrained genFromSpec
#4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/improve-genFromSpec
branch
from
1dcb89a to
e3d9118
Compare
* use the existing error handling mechanism from constrained * remove usage of unsafePerformIO * remove incorrectly placed `catch` and catching of `AnyException`
teodanciu
force-pushed
the
td/improve-genFromSpec
branch
from
e3d9118 to
7ee79df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchand catching ofAnyExceptionCloses #4802
Description
Checklist
CHANGELOG.mdfiles updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles when necessary, according to theversioning process.
.cabalfiles updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlupdated (usescripts/gen-hie.sh)