Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomised certs for imp-tests #4830

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jan 10, 2025

Description

  • Add randomised cert functions
  • Replace all RegTxCert use sites with the new function
  • Open an issue to replace all UnRegTxCert use sites with the corresponding new function once the functionality is at parity in the formal spec

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/randomise-unregcert branch from 77d9def to c5b7181 Compare January 10, 2025 14:55
@aniketd aniketd changed the title Add arbitrary(Un)RegTxCert for Imptests Add randomised certs for imp-tests Jan 10, 2025
- arbitraryRegTxCert
- arbitraryUnRegTxCert
@aniketd aniketd force-pushed the aniketd/randomise-unregcert branch from c5b7181 to 11858c9 Compare January 10, 2025 14:57
Credential 'Staking ->
ImpTestM era (TxCert era)
arbitraryUnRegTxCert stakingCredential = do
keyDeposit <- getsNES (nesEsL . curPParamsEpochStateL . ppKeyDepositL)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong deposit. Lookup in UMap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant