Merge pull request #2871 from IntersectMBO/update_test_tx_view

feat: update tx view golden files
IntersectMBO · Jan 9, 2025 · bffa680 · bffa680
2 parents 3f3c39e + 90c1764
commit bffa680
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/cardano_node_tests/tests/data/test_tx_metadata_both_tx_body_json.out b/cardano_node_tests/tests/data/test_tx_metadata_both_tx_body_json.out
@@ -2,6 +2,7 @@
     "auxiliary scripts": null,
     "certificates": null,
     "collateral inputs": [],
+    "datums": [],
     "era": "Babbage",
     "fee": "190279 Lovelace",
     "inputs": [
@@ -32,6 +33,7 @@
     "reference inputs": [],
     "required signers (payment key hashes needed for scripts)": null,
     "return collateral": null,
+    "scripts": [],
     "total collateral": null,
     "update proposal": null,
     "validity range": {

diff --git a/cardano_node_tests/tests/data/test_tx_metadata_both_tx_json.out b/cardano_node_tests/tests/data/test_tx_metadata_both_tx_json.out
@@ -2,6 +2,7 @@
     "auxiliary scripts": null,
     "certificates": null,
     "collateral inputs": [],
+    "datums": [],
     "era": "Babbage",
     "fee": "190279 Lovelace",
     "inputs": [
@@ -32,6 +33,7 @@
     "reference inputs": [],
     "required signers (payment key hashes needed for scripts)": null,
     "return collateral": null,
+    "scripts": [],
     "total collateral": null,
     "update proposal": null,
     "validity range": {

diff --git a/cardano_node_tests/tests/test_cli.py b/cardano_node_tests/tests/test_cli.py
@@ -180,19 +180,21 @@ def test_tx_view(self, cluster: clusterlib.ClusterLib):
         common.get_test_id(cluster)
 
         tx_body = cluster.g_transaction.view_tx(tx_body_file=self.TX_BODY_FILE)
-        tx = cluster.g_transaction.view_tx(tx_file=self.TX_FILE)
 
         if '"redeemers":' not in tx_body:
             pytest.skip("unsupported old output format")
+        if '"datums":' not in tx_body:
+            pytest.skip("unsupported old output format")
 
         with open(self.TX_BODY_OUT_JSON, encoding="utf-8") as infile:
             tx_body_golden = infile.read()
+        assert tx_body == tx_body_golden.strip()
+
+        tx = cluster.g_transaction.view_tx(tx_file=self.TX_FILE)
 
         if '"governance actions":' in tx:
             issues.cli_799.finish_test()
 
-        assert tx_body == tx_body_golden.strip()
-
         with open(self.TX_OUT_JSON, encoding="utf-8") as infile:
             tx_golden = infile.read()
         assert tx == tx_golden.strip()