Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cja/update resistor capacitor symbols #165

Closed
wants to merge 5 commits into from

Conversation

callendorph
Copy link
Contributor

This makes some improvements to the resistor and capacitor symbol generator code.

I've also fixed a bug in the polarized capacitor rendering:

Broken:
Screenshot 2024-09-12 155854

Now Fixed
Screenshot 2024-09-12 155909

@callendorph callendorph requested a review from bhusang September 12, 2024 23:01
@callendorph
Copy link
Contributor Author

@jwatson0 - I've added a new dependency to JSL's slm.toml for maybe-utils. When the tests run - I don't see a call to slm to retrieve the dependencies:

https://github.com/JITx-Inc/jsl/actions/runs/10839998507/job/30081487228?pr=165#step:5:690

Is this expected ?

@jwatson0
Copy link
Contributor

The JSL Makefile doesn't currenty do anything with slm. It just calls jstanza on the tests.

Should we integrate the tests into an slm project?

stanza.proj also doesn't have build targets for main or test, so it seems that JSL isn't a full slm library yet.
I can add that if that's the desired step, which I assume it is.

@callendorph
Copy link
Contributor Author

stanza.proj also doesn't have build targets for main or test, so it seems that JSL isn't a full slm library yet.
I can add that if that's the desired step, which I assume it is.

We moved away from that approach because running the static binary build takes forever. The run-test mechanism was much much faster (ie 5 seconds vs 30+seconds).

That is why it is in the Makefile and not in the stanza.proj file.

Re slm - I think we may need to add a run-test command to slm if it doesn't already exist.

@jwatson0
Copy link
Contributor

jwatson0 commented Sep 12, 2024

much much faster

Oh, right, I remember now.

I also think we need a fetch command in slm to fetch all of the dependencies and not do any compilation. Maybe that would help in this case.

@callendorph
Copy link
Contributor Author

I also think we need a fetch command in slm to fetch all of the dependencies and not do any compilation. Maybe that would help in this case.

Agreed - that might be a more flexible model.

@callendorph
Copy link
Contributor Author

I have an idea for how to work around it - I need to debug it on another computer but let me see if I can get it work

I don't have `make` on Windows so I had to push something
and fix it on OS-X.
@callendorph
Copy link
Contributor Author

OK - @jwatson0 - it doesn't work because the docker container does not seem to have slm in it.
Is there a way that we can add slm to this docker container ?

@callendorph
Copy link
Contributor Author

Closed in favor of #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants