Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase out get-connected-net #172

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Phase out get-connected-net #172

merged 1 commit into from
Sep 23, 2024

Conversation

tjknoth
Copy link
Contributor

@tjknoth tjknoth commented Sep 23, 2024

Eventually we will probably delete this, for now I:

  • added an introspection get-connected-nets that returns all connected net statements
  • changed make-via-grid to just net directly to the target object
  • changed the corresponding field in PortInfo to a tuple
  • added a function connected-net on PortInfo that mimics the old functionality (for backwards compatibility)
    Another thing we will need to look at:
    make-thermal-vias assumes the existence of a single net statement for its geom statement. This will often not be true -- it still works since I reimplemented connected-net, but it will arbitrarily select the first net statement. Maybe this is fine, I'm not 100% sure

@tjknoth tjknoth requested a review from callendorph September 23, 2024 18:51
Copy link
Contributor

@callendorph callendorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for catching this!

@tjknoth tjknoth merged commit 9306a6c into main Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants