Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vias in topologies #175

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Support vias in topologies #175

merged 10 commits into from
Oct 17, 2024

Conversation

tjknoth
Copy link
Contributor

@tjknoth tjknoth commented Sep 25, 2024

instantiate a phantom pin per-via to enable usage in topologies.
Shouldn't be merged until a jitx-client bugfix gets through.

@tjknoth tjknoth requested a review from callendorph September 25, 2024 22:13
@callendorph
Copy link
Contributor

I tried running the diff-pair via structure example on 3.17.0 in examples/via-structures/diff-via-structure.stanza and I had trouble routing:

image

The diff insertion point I can't route to the diff-pair via structure.
Also note that when I show the labels I get p and p - it would be very useful if the labels showed p and n
When I select pads and press a - I see no other pads highlighted - so I think there might be an issue with the example at least or the generator at worst.

@tjknoth
Copy link
Contributor Author

tjknoth commented Sep 30, 2024

I forgot some net statements -- fixed that, which I think should enable routing.
Also changed the names to n and p.

When I select pads and press a - I see no other pads highlighted - so I think there might be an issue with the example at least or the generator at worst.

Do you mean when you select one of the two pads n or p? That's still happening even after i fixed the nets. Still poking.

@tjknoth
Copy link
Contributor Author

tjknoth commented Sep 30, 2024

Actually, I think the possible ends thing might be an issue with the example.
If you select one of the pads on the capacitors and select possible ends (ctrl+a), it will highlight the pads on the diff pairs.
Is there a different behavior you expect?

@callendorph
Copy link
Contributor

Diff Pair insertion point example seems to be working in 3.19.0:

Screenshot 2024-10-17 at 10 12 14 AM

@tjknoth
Copy link
Contributor Author

tjknoth commented Oct 17, 2024

Yep -- it won't work if you run from a clean state until 3.20 due to the placer bug.
I'll get this merged today anyways.

Copy link
Contributor

@callendorph callendorph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your help on this.
The unit tests pass when I run them locally.

val via-pitch = pitch(v) / 2.0

; First wrapper instance
inst via-pin-P : topo-via-pin(`p)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I have here is the symbol for the diff-pair via structures being two separate schematic symbols in this approach. I think that will make the schematic harder to read. Assuming the user uses the create-via-structure function - then at least these two symbols will be in the same sch group so they will be group together a bit.
I think this is fine for now until we can integrate via structures more directly in the JITX runtime.

@callendorph
Copy link
Contributor

Seems like the CI is fixed now too 🎉 🦖

@tjknoth tjknoth merged commit 4ded1e9 into main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants