Update BGA-simple.stanza: add example without balls missing from landpattern as syntax is somewhat unintuitive #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment with the syntax for a full ball grid without any inactive pads, as it took me a while (and some help fom Frederik) to figure it out myself.
bhusang
reviewed
Sep 29, 2024
| @@ -45,6 +45,9 @@ pcb-component test-BGA: | |||
| val planner = Perimeter-Matrix-Planner( | |||
| ; Pad A2 is not present | |||
| inactive = to-pad-island(grid, "A[2]"), | |||
| ; To get a full grid, set inactive to empty set | |||
| ; it is a required argument and can't be left out entirely: | |||
| ;inactive = [] | |||
There was a problem hiding this comment.
Yeah, the example for a full matrix should also be present using Full-Matrix-Planner. Thanks for the feedback.
|
@jwatson0 - The CI tests failed to run after I approved through the Github UI. Can you take a look at the logs when you get a chance ? |
|
Because this is coming from a fork outside our JITX-Inc organization, it doesn't have access to the credentials required by the build. Can we make this into a branch in our repo instead of a fork? |
|
I think @alijitx was going to submit a simple full matrix BGA landpattern |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment with the syntax for a full ball grid without any inactive pads, as it took me a while (and some help fom Frederik) to figure it out myself.