More Bug Fixes #184
Merged
More Bug Fixes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to pass port arrays and have them unpack into a format that the `port-to-pads` function will match against.
I had previously added this because the `bounds` function was looking for a `LandPatternPad` type as its argument. This is yet another case where attempting to use types is difficult if not impossible in JITX. I've converted `bounds` to use `JITXObject` instead and this removes the need for the seq function.
This function causes an ambiguous function definition error during compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tjknoth - I address the issues you brought up with the
to-lp-pd-seqfunction here.