Skip to content

Commit

Permalink
Remove EwaBicubic (#39)
Browse files Browse the repository at this point in the history
Firstly, it was incorrectly referencing ewa_robidoux, which _is_ a
bicubic but internally its `b` and `c` params take precedence over
anything a user might have passed to `EwaBicubic`, so functionally it
was equivalent to `EwaRobidoux`. Secondly, there is no "ewa_bicubic" to
replace it with; there's "bicubic" but I think we've got that kernel
sufficiently covered with `Bicubic` elsewhere.
  • Loading branch information
sgt0 authored Nov 24, 2024
1 parent b04b604 commit ed7e89e
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions vskernels/kernels/placebo.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

__all__ = [
'Placebo',
'EwaBicubic',
'EwaJinc',
'EwaLanczos',
'EwaGinseng',
Expand Down Expand Up @@ -100,20 +99,6 @@ def kernel_radius(self) -> int: # type: ignore
return 2


class EwaBicubic(Placebo):
_kernel = 'ewa_robidoux'

def __init__(self, b: float = 0.0, c: float = 0.5, radius: int | None = None, **kwargs: Any) -> None:
radius = kwargs.pop('taps', radius)

if radius is None:
from .bicubic import Bicubic

radius = Bicubic(b, c).kernel_radius

super().__init__(radius, b, c, **kwargs)


class EwaLanczos(Placebo):
_kernel = 'ewa_lanczos'

Expand Down

0 comments on commit ed7e89e

Please sign in to comment.