Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DynamicArray.java #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update DynamicArray.java #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...es/src/main/java/com/javaaid/hackerrank/solutions/datastructures/arrays/DynamicArray.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ public DynamicArray(int N) {

void appendValue(int x, int y, int N) {
int rowIndex = (x ^ lastAns) % N;
List<Integer> seq = seqList.get(rowIndex);
seq = seqList.get(rowIndex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you store the result in existing global variable seq, you will loose the initial input ref list.
So its better to use local variable instead of global.

seq.add(y);
}

private void printValue(int x, int y, int N) {
int colIndex = 0;
int rowIndex = (x ^ lastAns) % N;
List<Integer> seq = seqList.get(rowIndex);
seq = seqList.get(rowIndex);
colIndex = y % seq.size();
lastAns = seq.get(colIndex);
System.out.println(lastAns);
Expand Down