Remove CPU Limits from default values. #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FSchumacher
reviewed
Nov 30, 2024
| @@ -42,7 +42,7 @@ The command removes all the Kubernetes components associated with the chart and | |||
| | `affinity` | Add affinity rules to the deployment. | `{}` | | |||
| | `nodeSelector` | Add a nodeSelector to the deployment. | `{}` | | |||
| | `displayName` | Optional display name for the kubeseal instance | `""` | | |||
| | `resources.limits.cpu` | Limits CPU | `100m` | | |||
| | `resources.limits.cpu` | Limits CPU | `""` | | |||
There was a problem hiding this comment.
As we are not setting the value at all, isn't it more a null value?
There was a problem hiding this comment.
Yeah i also thought about that but i think empty is also valid for this table 😄
FSchumacher
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.