Skip to content

Commit

Permalink
fix: rotation card dimensions (#577)
Browse files Browse the repository at this point in the history
* fix: set initial image to have null parent order

* fix: language warning in test

* fix: revert library version to working rotation

* fix: storybook config
  • Loading branch information
storyworks authored May 9, 2022
1 parent eca1071 commit 089ad7e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 13 deletions.
10 changes: 2 additions & 8 deletions .storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,8 @@ const affectedStories = () => {

const stories = affectedProjects
.map((project) => {
if (
project === 'shared-storybook' ||
project === '' ||
project.includes('api-') ||
project.includes('-e2e')
)
return []
return storiesForProject[project]
if (project === '') return []
return storiesForProject[project] ?? []
})
.flat()

Expand Down
1 change: 1 addition & 0 deletions apps/journeys/src/components/Conductor/Conductor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
TreeBlock,
useBlocks
} from '@core/journeys/ui'
// Used to resolve dynamic viewport height on Safari
import Div100vh from 'react-div-100vh'
import { BlockFields_CardBlock as CardBlock } from '../../../__generated__/BlockFields'
import { JourneyProgress } from '../JourneyProgress'
Expand Down
11 changes: 7 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"notistack": "^2.0.3",
"react": "17.0.2",
"react-colorful": "^5.5.1",
"react-div-100vh": "^0.7.0",
"react-div-100vh": "^0.6.0",
"react-dom": "17.0.2",
"react-firebase-hooks": "^3.0.4",
"react-firebaseui": "^6.0.0",
Expand Down

3 comments on commit 089ad7e

@vercel
Copy link

@vercel vercel bot commented on 089ad7e May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 089ad7e May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 089ad7e May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

watch – ./

watch-jesusfilm.vercel.app
watch-git-main-jesusfilm.vercel.app
watch-one.vercel.app

Please sign in to comment.