Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW ONLY] Add SplitButton #733

Closed
wants to merge 32 commits into from
Closed

[REVIEW ONLY] Add SplitButton #733

wants to merge 32 commits into from

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Dec 19, 2024 •
edited
Loading

Recording2024-12-19130900-ezgif com-video-to-gif-converter

morgillo and others added 17 commits December 10, 2024 12:20
@hamen
add Swing Split Button samples to SwingComparisonTabPanel
2871cfd 
Signed-off-by: morgillo <morgillo@google.com>
@hamen
staging branch for #224 epic
67109db 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add styles PoC
5facd8f 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
step forward with DefaultSplitButton
2f1d0e3 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate on SplitButtons colors
68df842 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
WIP
482fc21 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate more on SplitButton
ff82454 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add KDOC to DefaultButton
b6e4113 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add KDOC for OutlinedButton
8117f90 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
WIP
14fe07e 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
clicking on the chevron doesn't mess up the focus of the split button
b4f650f 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
WIP
14d6ae3 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
WIP
2962689 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
fix button focus
d5f5b67 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
wrap up button popup menu
b01b0ca 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
waiting for next Compose for Desktop
3b8ae97 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add PopupContainer variant for SplitButton
ead72f4 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@rock3r rock3r self-requested a review December 19, 2024 12:14
@rock3r rock3r added the new component A new component to implement label Dec 19, 2024
@hamen
add showcase to Standalone
037baba 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
rock3r
rock3r reviewed Dec 19, 2024
View reviewed changes
ide-laf-bridge/src/main/kotlin/org/jetbrains/jewel/bridge/theme/IntUiBridgeSplitButton.kt Outdated Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/styling/SplitButtonStyle.kt Show resolved Hide resolved
.../ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/SwingComparisonTabPanel.kt Outdated Show resolved Hide resolved
.../ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/SwingComparisonTabPanel.kt Outdated Show resolved Hide resolved
.../ide-plugin/src/main/kotlin/org/jetbrains/jewel/samples/ideplugin/SwingComparisonTabPanel.kt Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt Outdated Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt Outdated Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt Outdated Show resolved Hide resolved
ui/src/main/kotlin/org/jetbrains/jewel/ui/component/Button.kt Show resolved Hide resolved
@hamen hamen changed the title Add SplitButton [REVIEW ONLY] Add SplitButton Dec 19, 2024
hamen added 6 commits December 19, 2024 16:43
@hamen
convert to expression body
7659933 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate on SplitButtonStyle
f72fc9d 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
remove old experiment code
6bd7703 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
extract splitButtons() in SwingComparisonTabPanel
9555385 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
iterate on SplitButton colors
3e09078 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
simplify the onPreviewKeyEvent in SplitButton
fba55e9 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added 7 commits December 20, 2024 16:01
@hamen
improve focus management for SplitButton
6c9d364 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add reference to OG Buttons
c729c62 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
make formatter and linter happy
35f8aa2
@hamen
iterate on KDOC for SplitButton
7d58146 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
add a tiny comment to the actuallyFocused in ButtonImpl
253ea34 
reference: #733 (comment)
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen
make formatter and linter happy
edbedae
@hamen
clean up
8dc7bb0 
Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
hamen added a commit to rock3r/intellij-community that referenced this pull request Jan 14, 2025
@hamen
Add SplitButton
b2402b0 
reference JetBrains/jewel#733

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>
@hamen hamen mentioned this pull request Jan 14, 2025
Closed
@hamen
Copy link
Collaborator Author

hamen commented Jan 14, 2025

Migrated to IJP as JetBrains/intellij-community#2909

@hamen hamen closed this Jan 14, 2025
intellij-monorepo-bot pushed a commit to JetBrains/intellij-community that referenced this pull request Jan 15, 2025
@hamen @intellij-monorepo-bot
Add SplitButton
4a0ea7e 
reference JetBrains/jewel#733

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

GitOrigin-RevId: a25d084ed04d880d871ba31912cb4988210d058b
intellij-monorepo-bot pushed a commit that referenced this pull request Jan 21, 2025
@hamen @intellij-monorepo-bot
Add SplitButton
2457006 
reference #733

Signed-off-by: Ivan Morgillo <imorgillo@gmail.com>

GitOrigin-RevId: a25d084ed04d880d871ba31912cb4988210d058b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r rock3r left review comments

Assignees

@hamen hamen

Labels
new component A new component to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamen @rock3r