Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : changes made in about us section #162 #170

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix : changes made in about us section #162 #170

merged 2 commits into from
Oct 24, 2024

Conversation

ishan657
Copy link
Contributor

Pull Request Title: #162
Add "About Us" Section in a Card

Pull Request Description:

  • Encapsulated the entire "About Us" section inside a card component for better UI structure and visual separation.
  • Updated CSS styles to ensure consistent layout within the card.

Screenshot 2024-10-24 042513

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hacktoberwall ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:34am

@ishan657
Copy link
Contributor Author

Please review the changes I have made and let me know if there is something wrong. I will fix it right away
ThankYou

@JollyJolli
Copy link
Owner

Hello there! Thanks for contributing, i love the result but there is something that you could add.
Just add the same background as the other cards and we are ready! Thank you.
image

@JollyJolli
Copy link
Owner

Perfect! Thank you 🫶🏻

@JollyJolli JollyJolli linked an issue Oct 24, 2024 that may be closed by this pull request
Edit "About Us" to be in a Card #162
Closed
@JollyJolli JollyJolli merged commit 9ecbb52 into JollyJolli:main Oct 24, 2024
2 checks passed
@ishan657
Copy link
Contributor Author

Thankyou @JollyJolli
For giving a chance to contribute on this issue, it was such a nice experience for me.
just one doubt should i delete the branch since my pr has been merged?

@JollyJolli
Copy link
Owner

Yeah you can do it, there isn't a problem 🫶🏻

@ishan657 ishan657 deleted the editAboutUs branch October 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phanty78 Phanty78 Awaiting requested review from Phanty78 Phanty78 is a code owner

@JollyJolli JollyJolli Awaiting requested review from JollyJolli JollyJolli is a code owner

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest2024 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit "About Us" to be in a Card
2 participants
@ishan657 @JollyJolli