fixed videos crashing (finally)

it was a missing library, the whole time
JordanSantiagoYT · Jan 2, 2025 · 990bbc5 · 990bbc5
1 parent a8ab974
commit 990bbc5
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 12 deletions.
diff --git a/hmm.json b/hmm.json
@@ -40,7 +40,7 @@
     {
       "name": "hxCodec",
       "type": "haxelib",
-      "version": "2.6.1"
+      "version": "2.5.1"
     },
     {
       "name": "hscript",

diff --git a/source/Conductor.hx b/source/Conductor.hx
@@ -2,11 +2,6 @@ package;
 
 import Song.SwagSong;
 
-/**
- * ...
- * @author
- */
-
 typedef BPMChangeEvent =
 {
 	var stepTime:Int;

diff --git a/source/Paths.hx b/source/Paths.hx
@@ -459,7 +459,9 @@ class Paths
 			return file;
 		}
 		#end
-		return 'assets/${(library != null) ? '$library/' : ''}videos/$key.$VIDEO_EXT';
+		final path:String = ('assets/${(library != null) ? '$library/' : ''}videos/$key.$VIDEO_EXT');
+		trace('Video Path before being passed to hxCodec: $path');
+		return path;
 	}
 	//Sound loading.
 	static public function sound(key:String, ?library:String):Sound

diff --git a/source/StartupState.hx b/source/StartupState.hx
@@ -71,7 +71,25 @@ class StartupState extends MusicBeatState
 	}
 
 	function doIntro() {
-		var theIntro:Int = FlxG.random.int(0, maxIntros);
+		#if debug // for testing purposes
+			final vidSprite = new MP4Handler(); // it plays but it doesn't show???
+			#if (hxCodec < "3.0.0")
+			vidSprite.playVideo(Paths.video('broCopiedDenpa', 'splash'), false, false);
+			vidSprite.finishCallback = function()
+			{
+				try { vidSprite.dispose(); }
+				catch (e) {}
+				FlxG.switchState(TitleState.new);
+			};
+			#else
+			vidSprite.play(Paths.video('broCopiedDenpa', 'splash'));
+			vidSprite.onEndReached.add(function(){
+				vidSprite.dispose();
+				FlxG.switchState(TitleState.new);
+			});
+			#end
+		#else
+		final theIntro:Int = FlxG.random.int(0, maxIntros);
 		switch (theIntro) {
 			case 0:
 				FlxG.sound.play(Paths.sound('startup', 'splash'));
@@ -106,15 +124,15 @@ class StartupState extends MusicBeatState
 				#if VIDEOS_ALLOWED
 					var vidSprite = new MP4Handler(); // it plays but it doesn't show???
 					#if (hxCodec < "3.0.0")
-					vidSprite.playVideo(Paths.video('bambiStartup'), false, false);
+					vidSprite.playVideo(Paths.video('bambiStartup', 'splash'), false, false);
 					vidSprite.finishCallback = function()
 					{
 						try { vidSprite.dispose(); }
 						catch (e) {}
 						FlxG.switchState(TitleState.new);
 					};
 					#else
-					vidSprite.play(Paths.video('bambiStartup'));
+					vidSprite.play(Paths.video('bambiStartup', 'splash'));
 					vidSprite.onEndReached.add(function(){
 						vidSprite.dispose();
 						FlxG.switchState(TitleState.new);
@@ -125,15 +143,15 @@ class StartupState extends MusicBeatState
 				#if VIDEOS_ALLOWED
 					var vidSprite = new MP4Handler(); // it plays but it doesn't show???
 					#if (hxCodec < "3.0.0")
-					vidSprite.playVideo(Paths.video('broCopiedDenpa'), false, false);
+					vidSprite.playVideo(Paths.video('broCopiedDenpa', 'splash'), false, false);
 					vidSprite.finishCallback = function()
 					{
 						try { vidSprite.dispose(); }
 						catch (e) {}
 						FlxG.switchState(TitleState.new);
 					};
 					#else
-					vidSprite.play(Paths.video('broCopiedDenpa'));
+					vidSprite.play(Paths.video('broCopiedDenpa', 'splash'));
 					vidSprite.onEndReached.add(function(){
 						vidSprite.dispose();
 						FlxG.switchState(TitleState.new);
@@ -151,6 +169,7 @@ class StartupState extends MusicBeatState
 					FlxTween.tween(logo, {alpha: 1, "scale.x": 1, "scale.y": 1}, 2, {ease: FlxEase.expoOut, onComplete: _ -> onIntroDone(1.5)});
 				} else doIntro();
 		}
+		#end
 	}
 
 	override function update(elapsed:Float)