Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing crash handler and full screen for Android #56

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Fixing crash handler and full screen for Android #56

merged 2 commits into from
Oct 29, 2023

Conversation

Stefan2008Git
Copy link

  • It's seems like the crash handler is came from SUtil instead from Main
  • Fixed full screen issue on Android because of latest OpenFL library

- It's seems like the crash handler is came from SUtil instead from Main
@Stefan2008Git
Copy link
Author

Here is the second fixes @JordanSantiagoYT for you

@Stefan2008Git
Copy link
Author

And i don't really know how to fix this error unfortunalety because i added something really stupid bruh

you forgot to add a " LOL
@JordanSantiagoYT
Copy link
Owner

fixed it lol

@Stefan2008Git
Copy link
Author

Stefan2008Git commented Oct 29, 2023

fixed it lol

I am gonna ask you something, but did you made firstly Note Spamming section tab for chart editor?

@Stefan2008Git
Copy link
Author

fixed it lol

I am gonna ask you something, but did you made firstly Note Spamming section for chart editor?

Or Denpa Engine did fist

@JordanSantiagoYT
Copy link
Owner

well it's a a combination of vman engine and denpa code, but when i discovered that the note multiplier wasnt functioning properly i did edit some code a little

@Stefan2008Git
Copy link
Author

well it's a a combination of vman engine and denpa code, but when i discovered that the note multiplier wasnt functioning properly i did edit some code a little

So basically i can use your code or i need to ask both engine for permission?

@JordanSantiagoYT
Copy link
Owner

yeah you can use my code

oh yeah internally it uses the name "stacking" instead of actually using "spamming"

@JordanSantiagoYT JordanSantiagoYT merged commit f84e1c5 into JordanSantiagoYT:main Oct 29, 2023
@Stefan2008Git
Copy link
Author

yeah you can use my code

oh yeah internally it uses the name "stacking" instead of actually using "spamming"

Alright. I will add that on 3.0.0 instead on 2.9.0 because it's for Halloween

@Stefan2008Git Stefan2008Git deleted the Fixed-crashHandler-and-fullScreen-issue-for-Android branch October 29, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants