Code consistency + return types

.phpunit.cache/test-results

@@ -1 +1 @@
-{"version":1,"defects":{"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetNamespace":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#0":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#3":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#4":7},"times":{"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldTestAttributeConstruction":0.002,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetTitle":0.001,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetRoot":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetNamespace":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Model\\UrlBreadcrumbTest::testShouldTestBreadcrumbsModel":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldConstruct":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#0":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#1":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#2":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#3":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#4":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#5":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#6":0}}
+{"version":1,"defects":{"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetNamespace":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#0":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#3":7,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#4":7},"times":{"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldTestAttributeConstruction":0.01,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetTitle":0.002,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetRoot":0.001,"Jugid\\AutomaticBreadcrumbs\\Tests\\Attribute\\BreadcrumbAttributeTest::testShouldGetNamespace":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Model\\UrlBreadcrumbTest::testShouldTestBreadcrumbsModel":0.002,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldConstruct":0.001,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#0":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#1":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#2":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#3":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#4":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#5":0,"Jugid\\AutomaticBreadcrumbs\\Tests\\Strategy\\HierarchyStrategyTest::testShouldDecomposeWithHierarchyStrategy#6":0}}

tests/Unit/Attribute/BreadcrumbAttributeTest.php

@@ -8,27 +8,30 @@
 class BreadcrumbAttributeTest extends TestCase 
 {
 
-    public function testShouldTestAttributeConstruction()
+    public function testShouldTestAttributeConstruction() : void
     {
         $this->expectNotToPerformAssertions();
         $breadcrumb = new Breadcrumb('Title');
         $breadcrumb = new Breadcrumb('Title', true);
         $breadcrumb = new Breadcrumb('Title', true, 'default');
     }
 
-    public function testShouldGetTitle() {
+    public function testShouldGetTitle() : void
+    {
         $breadcrumb = new Breadcrumb('Title');
         $this->assertEquals('Title', $breadcrumb->getTitle());
     }
 
-    public function testShouldGetRoot() {
+    public function testShouldGetRoot() : void
+    {
         $breadcrumb_false = new Breadcrumb('Title');
         $breadcrumb_true = new Breadcrumb('Title', true);
         $this->assertFalse($breadcrumb_false->isRoot());
         $this->assertTrue($breadcrumb_true->isRoot());
     }
 
-    public function testShouldGetNamespace() {
+    public function testShouldGetNamespace() : void
+    {
         $breadcrumb_default = new Breadcrumb('Title');
         $breadcrumb_with_specific_namespace = new Breadcrumb('Title', false, 'my_namespace');
         $this->assertEquals('default', $breadcrumb_default->getNamespace());

tests/Unit/Model/UrlBreadcrumbTest.php

@@ -8,7 +8,7 @@
 class UrlBreadcrumbTest extends TestCase 
 {
 
-    public function testShouldTestBreadcrumbsModel()
+    public function testShouldTestBreadcrumbsModel() : void
     {
         $breadcrumb = new UrlBreadcrumb('My breadcrumb', '/my/breadcrumb/path');
 

tests/Unit/Strategy/HierarchyStrategyTest.php

@@ -7,7 +7,8 @@
 
 class HierarchyStrategyTest extends TestCase {
 
-    public function testShouldConstruct() {
+    public function testShouldConstruct() : void 
+    {
         $this->expectNotToPerformAssertions();
 
         $strategy = new HierarchyStrategy();
@@ -16,12 +17,13 @@ public function testShouldConstruct() {
     /**
      * @dataProvider pathExpectedProvider
      */
-    public function testShouldDecomposeWithHierarchyStrategy(string $path, array $expected) {
+    public function testShouldDecomposeWithHierarchyStrategy(string $path, array $expected) : void 
+    {
         $strategy = new HierarchyStrategy();
         $this->assertEquals($expected, $strategy->decompose($path));
     }
 
-    public static function pathExpectedProvider() 
+    public static function pathExpectedProvider() : \Generator
     {
         yield ['path/to/page/', ['/path/to/page', '/path/to', '/path']];
         yield ['path/to/page', ['/path/to/page', '/path/to', '/path']];