Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 update after running #39

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yfractal
Copy link
Contributor

Fix issue 38

I think when same path, eg: "test", is reinserted into the RouteTable, we should update the RouteTable with the new path.

@yfractal
Copy link
Contributor Author

haven't pass the Travis CI :(


ERROR: LoadError: LoadError: LoadError: ArgumentError: invalid type for argument r in method definition for isequal at /home/travis/.julia/v0.4/Morsel/src/Routes.jl:81

https://github.com/JuliaWeb/Morsel.jl/blob/master/src/Routes.jl#L81

I haven't figured out why :( ...

@IainNZ
Copy link
Contributor

IainNZ commented Apr 18, 2015

Everything is broken on 0.4 right now so could be anything

@yfractal
Copy link
Contributor Author

@IainNZ
Thank you :) !

@yfractal yfractal force-pushed the issue-38-update-after-running branch from 5027c3e to 1677640 Compare April 22, 2015 03:28
@yfractal
Copy link
Contributor Author

The Julia Tuple changes, it has new syntax..
It should be

 typealias Bar Tuple{Function, Function}

in the newest Julia.

I have tried this in older version( Version 0.4.0-dev+2204 (2014-12-19 04:53 UTC) ), and the it doesn't work...

@aviks
Copy link

aviks commented Apr 22, 2015

Hi @yfractal yes, this syntax will not work in older builds. There is no point keeping compatibility with old builds for a development branch. However, we do want packages to be compatible with 0.3. The best way of doing that is via the Compat.jl package.

JuliaLang/Compat.jl#63

@yfractal
Copy link
Contributor Author

@aviks
Thank you!
The Compact.jl is so cool!

I will try to fix these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update routes after running
3 participants