Skip to content

Commit

Permalink
Merge #117
Browse files Browse the repository at this point in the history
117: Always return response headers when kwarg is passed r=mattBrzezinski a=mattBrzezinski

Not sure why I missed this, we always want to give back the `response.headers`, not `nothing`.

Co-authored-by: Matt Brzezinski <matt.brzezinski@invenia.ca>
Co-authored-by: Matt.jl <matt.brzezinski@invenia.ca>
  • Loading branch information
bors[bot] and mattBrzezinski authored Apr 15, 2020
2 parents 3283744 + 2ed198b commit b1d185b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "AWSCore"
uuid = "4f1ea46c-232b-54a6-9b17-cc2d0f3e6598"
version = "0.6.10"
version = "0.6.11"

[deps]
Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"
Expand Down
2 changes: 1 addition & 1 deletion src/AWSCore.jl
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ function do_request(r::AWSRequest; return_headers=false)
end

# Return raw data by default...
return (return_headers ? (response.body, nothing) : response.body)
return (return_headers ? (response.body, response.headers) : response.body)
end


Expand Down

2 comments on commit b1d185b

@mattBrzezinski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/13036

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.6.11 -m "<description of version>" b1d185b1989b10b5e09e5fbe0103615a21660d2b
git push origin v0.6.11

Please sign in to comment.