Add binary interval parsing #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
morris25
commented
Oct 8, 2021
|
For the sake of everyone's sanity I'm going to ignore the format suggestions on |
iamed2
requested changes
Oct 8, 2021
Co-authored-by: Eric Davies <iamed2@gmail.com>
added 2 commits
October 8, 2021 12:38
|
@iamed2 Is this good to go now? |
iamed2
approved these changes
Oct 15, 2021
|
Yes, go ahead and merge and register! |
@iamed2 I don't seem to have merge permissions. Would you mind clicking the button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #236. It turns out the
AdjustIntervalForTypmodis handled before the result is returned however some minorPeriodprocessing was required since Dates is a bit fussy about comparingCompoundPeriods.This fixes binary queries involving the postgres
intervaltype.