Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async is no longer the default #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

async is no longer the default #287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/AtomShell/window.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ end

"""
Window()
Window(electron_options::Dict; async=true)
Window(electron_options::Dict; async=false)

Create and open a new Window through Electron.

If `async==false`, this function blocks until the Window is fully initialized
and ready for you to communicate with it via javascript or the Blink API.
If `async==true`, this function doen't block until the Window is fully initialized
and ready for you to communicate with it via JavaScript or the Blink API.

The `electron_options` dict is used to initialize the Electron window. See here
for the full set of Electron options:
Expand Down