Including details about prints of simulate

[gsahonero]

No description provided.

[cncastillo]

@rkierulf There seems to be a few minor issues with the benchmarks/tests.

Are we still running the codecov for Metal? (I see the "Cannot submit coverage without Codecov key." in https://buildkite.com/julialang/komamri-dot-jl/builds/810).

If the PR is from a fork and not coming from "us", the benchmark.yml (GitHub) job fails due to not having the BUILDKITE_TOKEN. Maybe we should not run that action for external PRs. The benchmarks in Buildkite are not run.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (a2837ae) to head (a537cb0).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   90.52%   88.73%   -1.80%     
==========================================
  Files          51       51              
  Lines        2787     2787              
==========================================
- Hits         2523     2473      -50     
- Misses        264      314      +50     

Flag	Coverage Δ
base	88.20% <ø> (ø)
core	77.72% <ø> (-12.66%)	⬇️
files	93.55% <ø> (ø)
komamri	93.98% <ø> (ø)
plots	89.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
KomaMRICore/src/simulation/SimulatorCore.jl	90.54% <ø> (-4.06%)	⬇️

... and 6 files with indirect coverage changes

[cncastillo]

It seems that the codecov is not being processed properly for the GPU tests. In all pipelines it says "🔑 Skipping decryption of secrets" instead of "🔑 Decrypting secrets".

[rkierulf]

We shouldn't be running codecov for Metal since the step in runtests.yml is missing the plugin. For the Benchmark.yml file, I think we can prevent the action from running for external pull requests if we change the if statement in line 35 to: if: "!contains(github.event.head_commit.message, '[skip benchmarks]') && {{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}" community/community#26829 For the codecov issue with the GPU tests, this seems to have started recently, since none of the builds prior to #806 had this issue, but all of the builds starting from yesterday (#807+) do. I don't see codecov decryption errors for the other Julialang pipelines however, so it doesn't seem to be a general Buildkite issue. Is there anything with the repository that changed between Friday and yesterday? Ryan

…

On Tue, Jul 9, 2024 at 10:44 AM Carlos Castillo Passi < ***@***.***> wrote: It seems that the codecov is not being processed properly for the GPU tests. In all pipelines it says "🔑 Skipping decryption of secrets" instead of "🔑 Decrypting secrets". — Reply to this email directly, view it on GitHub <#431 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDSPWWMNR5FMSAC2D2N3JTTZLQAO3AVCNFSM6AAAAABKSFOUXOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGA2TIMJQGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[cncastillo]

I don't think I have changed anything :(. I think it could be related to a problem with the codecov_token in external PRs. Maybe I need to change something in the Buildkite config (?).