Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid GPU runners for CPU jobs, and fix hanging CPU tests #502

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Avoid GPU runners for CPU jobs, and fix hanging CPU tests #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a50e21d
Moved CPU tests and benchmarks to juliaecosystem. Reduced timeout lim…
cncastillo Oct 24, 2024
30c543c
Increased timeout slightly and arch
cncastillo Oct 29, 2024
e848554
Remove CPU codecov, and slightly increased timeout again.
cncastillo Oct 29, 2024
b7e6a08
Remove CPU coverage plugin and specify threads
cncastillo Oct 29, 2024
23070fa
num_cpu = 4, based on Lux
cncastillo Oct 29, 2024
bdb3b53
Modify num threads and cpus
cncastillo Oct 29, 2024
617cee6
Decreased num threads cpu tests
cncastillo Oct 29, 2024
bc63917
Remove ; julia_args=`--threads=4` from CPU tests.
cncastillo Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .buildkite/runbenchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,13 @@ steps:
artifact_paths:
- "benchmarks/results/*"
agents:
queue: "benchmark"
arch: "aarch64"
queue: "juliaecosystem"
num_cpus: "8"
env:
BENCHMARK_GROUP: CPU
JULIA_NUM_THREADS: "{{matrix.threads}}"
timeout_in_minutes: 120
timeout_in_minutes: 30

- label: "AMDGPU: Run Benchmarks"
plugins:
Expand Down Expand Up @@ -57,7 +59,7 @@ steps:
rocmgpu: "gfx1101"
env:
BENCHMARK_GROUP: AMDGPU
timeout_in_minutes: 120
timeout_in_minutes: 30

- label: "CUDA: Run Benchmarks"
plugins:
Expand Down Expand Up @@ -85,7 +87,7 @@ steps:
cuda: "*"
env:
BENCHMARK_GROUP: CUDA
timeout_in_minutes: 120
timeout_in_minutes: 30

- label: "Metal: Run Benchmarks"
plugins:
Expand Down Expand Up @@ -113,7 +115,7 @@ steps:
arch: "aarch64"
env:
BENCHMARK_GROUP: Metal
timeout_in_minutes: 120
timeout_in_minutes: 30

- label: "oneAPI: Run Benchmarks"
plugins:
Expand All @@ -140,7 +142,7 @@ steps:
intel: "*"
env:
BENCHMARK_GROUP: oneAPI
timeout_in_minutes: 120
timeout_in_minutes: 30

- wait: ~

Expand Down
18 changes: 8 additions & 10 deletions .buildkite/runtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,6 @@ steps:
plugins:
- JuliaCI/julia#v1:
version: "{{matrix.version}}"
- JuliaCI/julia-coverage#v1:
codecov: true
dirs:
- KomaMRICore/src
- KomaMRICore/ext
env:
TEST_GROUP: $TEST_GROUP
command: |
julia -e 'println("--- :julia: Instantiating project")
using Pkg
Expand All @@ -27,10 +20,15 @@ steps:

julia -e 'println("--- :julia: Running tests")
using Pkg
Pkg.test("KomaMRICore"; coverage=true, julia_args=`--threads=auto`)'
Pkg.test("KomaMRICore")'
agents:
queue: "juliagpu"
timeout_in_minutes: 60
arch: "aarch64"
queue: "juliaecosystem"
num_cpus: "4"
env:
TEST_GROUP: $TEST_GROUP
JULIA_NUM_THREADS: "4"
timeout_in_minutes: 30

- label: "AMDGPU: Run tests on v{{matrix.version}}"
matrix:
Expand Down
Loading