Skip to content

Commit

Permalink
Merge pull request #229 from jverzani/issue_228
Browse files Browse the repository at this point in the history
close #227,  close  #228
  • Loading branch information
jverzani authored May 26, 2020
2 parents 6ff4b25 + 88d5410 commit 033629d
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "Polynomials"
uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
license = "MIT"
author = "JuliaMath"
version = "1.1.0"
version = "1.1.1"

[deps]
Intervals = "d8418881-c3e1-53bb-8760-2df7ec849ed5"
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
Basic arithmetic, integration, differentiation, evaluation, and root finding over dense univariate polynomials.

[![](https://img.shields.io/badge/docs-stable-blue.svg)](https://JuliaMath.github.io/Polynomials.jl/stable)
[![](https://img.shields.io/badge/docs-latest-blue.svg)](https://JuliaMath.github.io/Polynomials.jl/dev)
[![Build Status](https://travis-ci.org/JuliaMath/Polynomials.jl.svg?branch=master)](https://travis-ci.org/JuliaMath/Polynomials.jl)
[![codecov](https://codecov.io/gh/JuliaMath/Polynomials.jl/branch/master/graph/badge.svg)](https://codecov.io/gh/JuliaMath/Polynomials.jl)

Expand Down
2 changes: 1 addition & 1 deletion src/common.jl
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ fit(P::Type{<:AbstractPolynomial},
y,
deg::Integer = length(x) - 1;
weights = nothing,
var = :x,) = fit'(P, promote(collect(x), collect(y))..., deg; weights = weights, var = var)
var = :x,) = fit(P, promote(collect(x), collect(y))..., deg; weights = weights, var = var)

# avoid issue 214
fit′(P::Type{<:AbstractPolynomial}, x, y, args...;kwargs...) = throw(MethodError("x and y do not produce abstract vectors"))
Expand Down
3 changes: 3 additions & 0 deletions test/StandardBasis.jl
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,9 @@ end
@test_throws MethodError fit(Polynomial, rand(2,2), rand(2,2))

end

# test default (issue #228)
fit(1:3, rand(3))
end

@testset "Values" begin
Expand Down

2 comments on commit 033629d

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/15427

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.1.1 -m "<description of version>" 033629d47009f125a5003a8e61538edc7a37f2c0
git push origin v1.1.1

Please sign in to comment.