Update OpenSpiel to new libcxxwrap / libjulia #2325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
fingolfin
force-pushed
the
mh/OpenSpiel
branch
from
b5cdf47 to
858d0bf
Compare
fingolfin
commented
Dec 29, 2020
| -DCMAKE_INSTALL_PREFIX=$prefix \ | ||
| -DCMAKE_TOOLCHAIN_FILE=${CMAKE_TARGET_TOOLCHAIN} \ | ||
| -DJulia_PREFIX=${prefix} \ | ||
| ../open_spiel/ |
There was a problem hiding this comment.
I took the liberty of sorting these arguments alphabetically and generally aligning them with other JLLs, in the hope that this will help a bit with future maintenance.
fingolfin
commented
Dec 29, 2020
| ] | ||
| include("../../L/libjulia/common.jl") | ||
| platforms = libjulia_platforms(julia_version) | ||
| platforms = expand_cxxstring_abis(platforms) |
There was a problem hiding this comment.
This part of the change expands the number of supported platforms substantially; but many currently don't build, due to various issues. I note that upstream now is at version 0.2.0, so some of them may be fixed there (but of course also new ones may have been introduced).
One is in the upstream C++ code:
/workspace/srcdir/open_spiel/open_spiel/utils/json.cc:66:64: error: no matching function for call to ‘min(long unsigned int, std::basic_string_view<char>::size_type)’
SPIEL_CHECK_EQ(error, str.substr(0, std::min(30ul, str.size())));Patching this with a fix is easy enough, but I am not sure it's worth the effort -- is there any interest in supporting more platforms?
|
I've made some tests. It seems that I can successfully build this package of Not sure if I need #2301 |
|
To test this locally, you need:
I usually do something like this, where |
|
You can of course also forgo building locally and simply let the Yggdrasil bots do the job: you can open your own PR for this package, by starting with the content of my commit and then editing it as you like, e.g. by switching it to use version 0.2.0. |
Merged
Thanks! I'll give it a try this weekend. |
|
@findmyway any news on this? |
|
Hi @fingolfin , Sorry it was delayed due to some personal issues. Working on it now. |
|
😢 Still no luck. See https://github.com/JuliaPackaging/Yggdrasil/pull/2437/checks?check_run_id=1752851007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some progress towards issue #2160
Should not be merged before @findmyway had a chance to review and comment. Also, there are some questions to discuss:
0.3.XwhereXis equal to the one in the Julia version 1.X. However, then packages using this JLL may need to be updated.