support for 1.9 extensions #143

longemen3000 · 2023-05-13T23:56:12Z

moves SpecialFunctions, Unitful and Juno support into extensions.

giordano

Thanks for tackling this!

I'm also inclined towards removing the Juno stuff altogether: as far as I know it's broken, I doubt anyone uses it, Juno itself is discontinued. But this is besides the point of this PR.

ext/MeasurementsJunoExt.jl

ext/MeasurementsSpecialFunctionsExt.jl

ext/MeasurementsUnitfulExt.jl

src/Measurements.jl

src/show.jl

test/runtests.jl

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

codecov · 2023-05-14T00:36:08Z

Codecov Report

Merging #143 (9c63073) into master (f1d6e89) will increase coverage by 1.28%.
The diff coverage is 25.00%.

❗ Current head 9c63073 differs from pull request most recent head cce870b. Consider uploading reports for the commit cce870b to get more accurate results

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   95.63%   96.91%   +1.28%     
==========================================
  Files          12        9       -3     
  Lines         756      616     -140     
==========================================
- Hits          723      597     -126     
+ Misses         33       19      -14

Impacted Files	Coverage Δ
src/show.jl	`100.00% <ø> (+16.66%)`	⬆️
src/Measurements.jl	`77.41% <25.00%> (-9.25%)`	⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

longemen3000 · 2023-05-14T00:55:17Z

Finally, tests pass hahah. the __init__ function requires that particular arrangement to work on earlier versions (based on SciML/DiffEqBase.jl@c2de920) .
I think that there will be some problems with Aqua.jl afterwards, because there isn't any compat of the @required functions.

src/Measurements.jl

giordano · 2023-05-14T11:57:59Z

src/Measurements.jl

+if !isdefined(Base, :get_extension)
+    using Requires
+end 
+
 function __init__()
-    @require Unitful="1986cc42-f94f-5a68-af5c-568840ba703d" include("unitful.jl")
-    @require SpecialFunctions="276daf66-3868-5448-9aa4-cd146d93841b" include("special-functions.jl")
+    @static if !isdefined(Base, :get_extension)
+        @require Unitful="1986cc42-f94f-5a68-af5c-568840ba703d" include("../ext/MeasurementsUnitfulExt.jl")
+        @require SpecialFunctions="276daf66-3868-5448-9aa4-cd146d93841b" include("../ext/MeasurementsSpecialFunctionsExt.jl")
+        @require Juno="e5e0dc1b-0480-54bc-9374-aad01c23163d" include("../ext/MeasurementsJunoExt.jl")
+    end
 end


At this point just use

@static if !isdefined(Base, :get_extension) using Requires function __init__() @require Unitful="1986cc42-f94f-5a68-af5c-568840ba703d" include("../ext/MeasurementsUnitfulExt.jl") @require SpecialFunctions="276daf66-3868-5448-9aa4-cd146d93841b" include("../ext/MeasurementsSpecialFunctionsExt.jl") @require Juno="e5e0dc1b-0480-54bc-9374-aad01c23163d" include("../ext/MeasurementsJunoExt.jl") end end

Having a duplicate if looks pointless and you avoid having an __init__ function completely when not needed.

test/runtests.jl

Project.toml

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

ext/MeasurementsRecipesBaseExt.jl

test/runtests.jl

ext/MeasurementsRecipesBaseExt.jl

ext/MeasurementsSpecialFunctionsExt.jl

ext/MeasurementsRecipesBaseExt.jl

Project.toml

longemen3000 · 2023-05-14T23:10:17Z

the loading of RecipesBase was done in a backwards-compatible (https://pkgdocs.julialang.org/dev/creating-packages/#Transition-from-normal-dependency-to-extension) but aqua complains about that (and is the reason the Aqua test fail)

test/runtests.jl

longemen3000 · 2023-05-14T23:25:16Z

the tests are now explicitly failing for JuliaTesting/Aqua.jl#105 (the Pkg order is different than the order Aqua expects), should be fixed by JuliaTesting/Aqua.jl#106 ?

giordano · 2023-05-14T23:28:48Z

Can't you just change the order to make the test pass or am I missing something?

longemen3000 · 2023-05-14T23:44:47Z

i will try, hope that a Pkg.resolve() does not change the proposed order

longemen3000 · 2023-05-15T02:11:01Z

Tests seems to pass (now with Aqua.jl)

ext/MeasurementsRecipesBaseExt.jl

test/runtests.jl

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

giordano · 2023-05-15T22:21:11Z

Ok, I think this is in a good shape now. Thanks again for this!

LebedevRI · 2023-05-16T01:18:08Z

src/Measurements.jl

+if !isdefined(Base,:get_extension)
+    using Requires
+    using RecipesBase
+    include("../ext/MeasurementsRecipesBaseExt.jl")


Is it intentional that only this single extension is outside of the next block?

this package supports julia 1.0. for some reason, using one isdefined block failed.

I see, thanks.

longemen3000 added 2 commits May 13, 2023 19:43

start work on 1.9 extensions

85a9994

move Juno into an extension

54898d7

giordano linked an issue May 14, 2023 that may be closed by this pull request

Move to pkgextensions for Julia v1.9+ #133

Closed

move messages to the top of the file, fix SpecialFunctions

1004d52

giordano reviewed May 14, 2023

View reviewed changes

longemen3000 and others added 8 commits May 13, 2023 20:09

Update src/Measurements.jl

25de641

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Update ext/MeasurementsJunoExt.jl

8807e0b

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Update src/show.jl

437fdeb

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Update ext/MeasurementsJunoExt.jl

805722d

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Update ext/MeasurementsSpecialFunctionsExt.jl

8bed813

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

@static if !isdefined is required in the requires block

a185cce

use result in MeasurementsSpecialFunctionsExt, remove an extra space

f4d17f9

use value and uncertainty in MeasurementsUntifulExt.jl

faf5d80

move around the @static declaration in init, remove from unneeded places

ddff2d2

giordano reviewed May 14, 2023

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

longemen3000 and others added 7 commits May 14, 2023 12:24

Update src/Measurements.jl

1eaa2b5

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

reactivate Aqua tests

9a702ac

use 1 static ifdefined statement

1565150

use 1 static ifdefined statement

f3e7233

add RecipesBase as an extension

7493089

typo

f933db5

try again to move all cond code into 1 @static ifdefined

3a9913d

giordano reviewed May 14, 2023

View reviewed changes

ext/MeasurementsRecipesBaseExt.jl Outdated Show resolved Hide resolved

giordano reviewed May 14, 2023

View reviewed changes

test/runtests.jl Outdated Show resolved Hide resolved

giordano reviewed May 14, 2023

View reviewed changes

ext/MeasurementsRecipesBaseExt.jl Show resolved Hide resolved

giordano reviewed May 14, 2023

View reviewed changes

ext/MeasurementsSpecialFunctionsExt.jl Show resolved Hide resolved

remove unused files, move require block at the end

a66dd2b

longemen3000 added 2 commits May 14, 2023 19:00

trailing end space

df4499c

move RecipesBase out of the condition

b8d89b3

giordano reviewed May 14, 2023

View reviewed changes

ext/MeasurementsRecipesBaseExt.jl Outdated Show resolved Hide resolved

giordano reviewed May 14, 2023

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

typo in Project.toml

3f1b046

longemen3000 added 2 commits May 14, 2023 19:14

add RecipesBase to ignored stale deps

9de9028

typo in Aqua kwarg

1eef350

giordano reviewed May 14, 2023

View reviewed changes

test/runtests.jl Outdated Show resolved Hide resolved

longemen3000 added 5 commits May 14, 2023 19:46

change order to the one Aqua.jl likes

3168797

change order of extensions (Aqua.jl)

4c1d026

typo in Aqua.test_stale_deps

1601b10

add Requires to stale_deps

dff605d

Make PlotRecipes work

c5d61dc

longemen3000 added 2 commits May 14, 2023 22:37

use 1 if isdefined statement (take 3)

746b84d

revert using 1 statement. julia 1.0 does not like that

e717cd3

giordano reviewed May 15, 2023

View reviewed changes

ext/MeasurementsRecipesBaseExt.jl Outdated Show resolved Hide resolved

test/runtests.jl Outdated Show resolved Hide resolved

longemen3000 and others added 2 commits May 15, 2023 15:31

Update test/runtests.jl

056c982

Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>

Update MeasurementsRecipesBaseExt.jl

cce870b

giordano merged commit 0b54af0 into JuliaPhysics:master May 15, 2023

LebedevRI reviewed May 16, 2023

View reviewed changes

giordano mentioned this pull request May 18, 2023

Symbolics.jl support #144

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for 1.9 extensions #143

support for 1.9 extensions #143

longemen3000 commented May 13, 2023

giordano left a comment

codecov bot commented May 14, 2023 •

edited

Loading

longemen3000 commented May 14, 2023 •

edited

Loading

giordano May 14, 2023

longemen3000 commented May 14, 2023

longemen3000 commented May 14, 2023

giordano commented May 14, 2023

longemen3000 commented May 14, 2023

longemen3000 commented May 15, 2023

giordano commented May 15, 2023

LebedevRI May 16, 2023

longemen3000 May 16, 2023

LebedevRI May 16, 2023

support for 1.9 extensions #143

support for 1.9 extensions #143

Conversation

longemen3000 commented May 13, 2023

giordano left a comment

Choose a reason for hiding this comment

codecov bot commented May 14, 2023 • edited Loading

Codecov Report

longemen3000 commented May 14, 2023 • edited Loading

giordano May 14, 2023

Choose a reason for hiding this comment

longemen3000 commented May 14, 2023

longemen3000 commented May 14, 2023

giordano commented May 14, 2023

longemen3000 commented May 14, 2023

longemen3000 commented May 15, 2023

giordano commented May 15, 2023

LebedevRI May 16, 2023

Choose a reason for hiding this comment

longemen3000 May 16, 2023

Choose a reason for hiding this comment

LebedevRI May 16, 2023

Choose a reason for hiding this comment

codecov bot commented May 14, 2023 •

edited

Loading

longemen3000 commented May 14, 2023 •

edited

Loading