Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Documenter v1 #370

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Update to Documenter v1 #370

merged 3 commits into from
Dec 29, 2024

Conversation

oschulz
Copy link
Member

@oschulz oschulz commented Feb 1, 2024

No description provided.

@oschulz oschulz requested a review from fhagemann February 1, 2024 20:47
docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated Show resolved Hide resolved
@oschulz
Copy link
Member Author

oschulz commented Feb 2, 2024

@fhagemann there are a bunch of errors "invalid local link/image: path pointing to a file outside of build directory in src/api.md" now with Documenter v1, not sure if Documenter has just become more picky with checks, of if this a new requirement in Documenter v1.

@fhagemann
Copy link
Collaborator

The problem is that the docstrings include links to images (which anyhow did not seem to work previously).
I removed the lines from the respective docstrings, let's see whether this fixes the failing tests.

@fhagemann
Copy link
Collaborator

fhagemann commented Feb 5, 2024

I‘m a bit concerned about the fact that the docs now take longer than the tests (?) @oschulz

it used to be something like 6min in the past, now 40 min

@oschulz
Copy link
Member Author

oschulz commented Feb 5, 2024

I‘m a bit concerned about the fact that the docs now take longer than the tests

Yes, that's no good. I just don't know why ...

@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Sep 22, 2024
@fhagemann fhagemann force-pushed the documenter-update branch 7 times, most recently from 4503f73 to 38a3a88 Compare December 29, 2024 20:19
@fhagemann
Copy link
Collaborator

Building the documentation in julia-1.10 for now, because it takes somewhat longer on julia-1.11

@fhagemann fhagemann merged commit 652e8ee into main Dec 29, 2024
9 checks passed
@fhagemann fhagemann deleted the documenter-update branch December 30, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants