Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce Requires dependency for LegendHDF5IO #411

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Reintroduce Requires dependency for LegendHDF5IO #411

merged 3 commits into from
Sep 13, 2024

Conversation

fhagemann
Copy link
Collaborator

As LegendHDF5IO is not registered in General or stdlib, we cannot release v0.10.0 with LegendHDF5IO in the [weakdeps]. A quick workaround is to reintroduce Requires to deal with this.

Long term plans could then be:

  • register LegendHDF5IO or a part of it
  • move the extension to LegendHDF5IO
  • simply keeping the Requires dependency

@fhagemann fhagemann requested a review from oschulz September 12, 2024 16:28
@fhagemann fhagemann added the dependencies Pull requests that update a dependency file label Sep 13, 2024
@fhagemann fhagemann merged commit 553119d into main Sep 13, 2024
9 checks passed
@fhagemann fhagemann deleted the requires branch September 13, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants