-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IsotropicChargeDriftModel and add more materials #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, in principle, looks good to me. I will have a detailed look st this later.
Could you maybe separate your first commit into two (one introducing the model, the other one adding new materials)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I will spend some time to write tests for this, but afteerwards, this should be good to go.
d062dcc
to
a9bd9b4
Compare
Sorry for all this force pushing, but the tests I added should also be good to go now. |
@Padniuk Thanks for the PR! We will probably leave this on ]add SolidStateDetectors#main |
This model was called as IsotropicMobilityChargeDriftModel because it uses identity-like mobility tensor:
The semiconductor should have material properties μ_e and μ_h. Like in example:
The usage examples are the following:
Additionally two new materials were added:$CsPbBr_{3}$ and lead: