Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outsource discretization methods to modules #775

Merged
merged 13 commits into from
Feb 9, 2024
Merged

Conversation

schillic
Copy link
Member

@schillic schillic commented Feb 6, 2024

The first commit is taken from #770.

I had to move some set operations to another module.

@schillic schillic force-pushed the schillic/discretize branch 3 times, most recently from 863e048 to 45d12da Compare February 7, 2024 09:57
@schillic schillic marked this pull request as ready for review February 7, 2024 10:48
Copy link
Member

@mforets mforets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🚀

@schillic schillic force-pushed the schillic/discretize branch from 45d12da to 45e8ceb Compare February 9, 2024 16:20
@schillic schillic force-pushed the schillic/discretize branch from 45e8ceb to 41d3d63 Compare February 9, 2024 17:20
@schillic schillic merged commit b4ed0fa into master Feb 9, 2024
6 checks passed
@schillic schillic deleted the schillic/discretize branch February 9, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants