Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace requires macro with require #848

Closed
wants to merge 1 commit into from
Closed

Replace requires macro with require #848

wants to merge 1 commit into from

Conversation

schillic
Copy link
Member

No description provided.

@schillic schillic marked this pull request as ready for review June 16, 2024 15:52
@mforets
Copy link
Member

mforets commented Aug 28, 2024 •
edited
Loading

why is @requires no longer supported? it looks like more compact notation than the alternative.

@schillic
Copy link
Member Author

schillic commented Aug 28, 2024 •
edited
Loading

I prefer to have only one version everywhere. But you are right that it is a bit more compact. How about moving the implementation to ReachabilityBase as an alternative @require method without the module argument?

EDIT: Ha, there is actually JuliaReach/ReachabilityBase.jl#44.

@schillic schillic mentioned this pull request Sep 18, 2024
Merged
@schillic schillic deleted the schillic/require branch September 19, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schillic @mforets