Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: SMILES v0.1.0 #11450

Closed
wants to merge 1 commit into from
Closed

New package: SMILES v0.1.0 #11450

wants to merge 1 commit into from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Mar 23, 2020 •
edited
Loading

@JuliaRegistrator JuliaRegistrator mentioned this pull request Mar 23, 2020
Open
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2020 •
edited
Loading

Your new package pull request does not meet the following guidelines for auto-merging:

  • Name does not meet all of the following: starts with an uppercase letter, ASCII alphanumerics only, ends in a lowercase letter. Important note: It is okay to have a package name that ends in an uppercase letter. However, you will need to wait until a registry maintainer manually approves the name.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@caseykneale
Copy link

caseykneale commented Mar 24, 2020 •
edited by DilumAluthge
Loading

Just a heads up SMILES stands for : Simplified molecular-input line-entry system

Also compathelper fixed my compat issues... Do I need to do anything to fix them in here?

[noblock]

@DilumAluthge
Copy link
Member

Retrigger Registrator. This will update the pull request.

[noblock]

@DilumAluthge
Copy link
Member

DilumAluthge commented Mar 24, 2020 •
edited
Loading

Would it make more sense to call it OpenSMILES.jl?

[noblock]

@JuliaRegistrator
New package: SMILES v0.1.0
151ab28 
UUID: 29c4880b-f2d1-40f2-9463-012547100b04
Repo: https://github.com/caseykneale/SMILES.jl.git
Tree: 0e71671de5d4522e57716fa48b0567fc8b710fae

Registrator tree SHA: unknown
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/smiles/29c4880b/v0.1.0 branch from 4441437 to 151ab28 Compare March 24, 2020 08:56
@caseykneale
Copy link

caseykneale commented Mar 24, 2020 •
edited by DilumAluthge
Loading

It could, my concern is - my port of opensmiles might not be perfect :(

[noblock]

@DilumAluthge
Copy link
Member

It's up to you. I think OpenSmiles.jl would be better, but it's your package.

[noblock]

@caseykneale
Copy link

caseykneale commented Mar 24, 2020 •
edited by DilumAluthge
Loading

whats the process to rename a package? Do I have to rename the repo and everything? Will anything break if I just manually change stuff? If its a big hassle I'll just stick with SMILES

[noblock]

@DilumAluthge
Copy link
Member

You’d have to rename the GitHub repository, and do a find/replace inside your repo.

[noblock]

@caseykneale
Copy link

rename was successful made a new PR I guess? #11506

@giordano giordano closed this Mar 24, 2020
@giordano giordano deleted the registrator/smiles/29c4880b/v0.1.0 branch March 24, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaRegistrator @caseykneale @DilumAluthge @giordano