Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPT #1615

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Remove CPT #1615

merged 2 commits into from
Aug 29, 2022

Conversation

Affie
Copy link
Member

@Affie Affie commented Aug 26, 2022

close #1562

@Affie Affie self-assigned this Aug 26, 2022
@Affie Affie added this to the v0.31.0 milestone Aug 26, 2022
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1615 (df40b19) into master (f3864a5) will increase coverage by 20.90%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1615       +/-   ##
===========================================
+ Coverage   56.56%   77.46%   +20.90%     
===========================================
  Files          73       73               
  Lines        5095     5406      +311     
===========================================
+ Hits         2882     4188     +1306     
+ Misses       2213     1218      -995     
Impacted Files Coverage Δ
src/entities/FactorOperationalMemory.jl 100.00% <100.00%> (ø)
src/services/CalcFactor.jl 88.33% <100.00%> (+3.65%) ⬆️
src/services/DeconvUtils.jl 68.96% <100.00%> (+68.96%) ⬆️
src/services/EvalFactor.jl 85.63% <100.00%> (+10.35%) ⬆️
src/services/NumericalCalculations.jl 92.47% <100.00%> (+23.65%) ⬆️
src/services/CompareUtils.jl 15.00% <0.00%> (-0.79%) ⬇️
src/NeedsResolution.jl 7.14% <0.00%> (-0.55%) ⬇️
src/Deprecated.jl 0.00% <0.00%> (ø)
src/ODE/DERelative.jl 100.00% <0.00%> (ø)
src/entities/CliqueTypes.jl 100.00% <0.00%> (ø)
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie requested a review from dehann August 26, 2022 10:18
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for removing CPT. This PR does create the technical debt of using future thread specific memory in CCW. So the old CPT fields will have to be removed from CCW again.

src/entities/FactorOperationalMemory.jl Show resolved Hide resolved
src/services/NumericalCalculations.jl Outdated Show resolved Hide resolved
@Affie
Copy link
Member Author

Affie commented Aug 26, 2022

Good for removing CPT. This PR does create the technical debt of using future thread specific memory in CCW. So the old CPT fields will have to be removed from CCW again.

Technical debt can be captured here #1616

@dehann
Copy link
Member

dehann commented Aug 29, 2022

thanks Johan, you can merge this one too when you are ready.

@Affie Affie merged commit 0cfb4f6 into master Aug 29, 2022
@Affie Affie deleted the 22Q3/maint/rem_cpt branch August 29, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CPT (should be replaced by CalcFactor)
2 participants