Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform schedulers with correct number of matches. #259

Open
wants to merge 1 commit into
base: ale/3.0
Choose a base branch
from

Conversation

gkronber
Copy link
Collaborator

@gkronber gkronber commented Jan 23, 2025

This PR fixes a bug where the schedulers are informed with the accumulated number of matches over all rules, instead of the number of matches for each individual rule. As a consequence of the bug, the BackoffScheduler deactivated all rules simulataneuously, instead of deactivating only the rules that produce a large number of matches.

As a consequence of the bugfix, the BackoffScheduler now starts to deactivate individual rules later (as intended!), which leads to more matches for the benchmarks and longer runtimes.

A larger change has been tested in #249, but that would require a complete overhaul of the scheduler interface.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (b960db9) to head (521318f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           ale/3.0     #259      +/-   ##
===========================================
+ Coverage    81.42%   81.44%   +0.01%     
===========================================
  Files           19       19              
  Lines         1497     1498       +1     
===========================================
+ Hits          1219     1220       +1     
  Misses         278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Results

egg-sym egg-cust MT@521318ff9d5... MT@b960db95f36... egg-sym/MT@521... egg-cust/MT@52... MT@b960db95f36...
egraph_addexpr 1.45 ms 5.09 ms 4.98 ms 0.285 0.979
basic_maths_simpl2 13.8 ms 5.26 ms 23.3 ms 19.4 ms 0.589 0.225 0.83
prop_logic_freges_theorem 2.55 ms 1.55 ms 1.06 ms 1.05 ms 2.39 1.46 0.989
calc_logic_demorgan 61.1 μs 35.1 μs 77.3 μs 75.7 μs 0.79 0.453 0.979
calc_logic_freges_theorem 22.1 ms 11.6 ms 41.6 ms 41 ms 0.531 0.278 0.987
basic_maths_simpl1 6.39 ms 2.88 ms 51.8 ms 4.61 ms 0.123 0.0555 0.089
egraph_constructor 0.0855 μs 0.0955 μs 0.0963 μs 0.895 1.01
prop_logic_prove1 35.7 ms 13.3 ms 142 ms 41.3 ms 0.252 0.094 0.291
prop_logic_demorgan 81.4 μs 44.8 μs 93.7 μs 94 μs 0.869 0.478 1
while_superinterpreter_while_10 18.1 ms 18 ms 0.995
prop_logic_rewrite 112 μs 112 μs 1.01
time_to_load 119 ms 119 ms 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants