Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Registration sub types as data objects #239

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 12, 2024

Improves toString output, especially on JS, which currently translates to [object Object] (rather than Register or Deregister).

@twyatt twyatt added the patch Changes that should bump the PATCH version number label Jan 12, 2024
Improves `toString` output, especially on JS, which currently translates
to `[object Object]` (rather than `Register` or `Deregister`).
@twyatt twyatt force-pushed the twyatt/registration/data-object branch from d50ab10 to 28c92a8 Compare January 12, 2024 22:20
@twyatt twyatt marked this pull request as ready for review January 12, 2024 22:20
@twyatt twyatt requested a review from a team as a code owner January 12, 2024 22:20
@twyatt twyatt requested review from sdonn3 and davertay-j January 12, 2024 22:20
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (56a59f1) 57.25% compared to head (28c92a8) 57.97%.
Report is 165 commits behind head on main.

Files Patch % Lines
koap/src/commonMain/kotlin/Message.kt 40.00% 12 Missing ⚠️
koap/src/commonMain/kotlin/Debug.kt 25.00% 3 Missing ⚠️
koap/src/commonMain/kotlin/Decoder.kt 66.66% 2 Missing ⚠️
koap/src/commonMain/kotlin/ByteArrayReader.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #239      +/-   ##
============================================
+ Coverage     57.25%   57.97%   +0.71%     
  Complexity       11       11              
============================================
  Files             8        8              
  Lines           613      652      +39     
  Branches        145      144       -1     
============================================
+ Hits            351      378      +27     
- Misses          223      235      +12     
  Partials         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twyatt twyatt enabled auto-merge (squash) January 12, 2024 23:24
@twyatt twyatt merged commit 6390817 into main Jan 16, 2024
2 checks passed
@twyatt twyatt deleted the twyatt/registration/data-object branch January 16, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Changes that should bump the PATCH version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants