Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/api/libraryManageApi.ts
Outdated
| book: () => [...libraryManageKeys.base, 'books'] as const, | ||
| borrowInfo: () => [...libraryManageKeys.base, 'borrow-infos'] as const, | ||
| bookManageList: (params: BookListSearch) => [...libraryManageKeys.book(), params] as const, | ||
| bookDetail: (params: number) => [...libraryManageKeys.book(), params] as const, |
There was a problem hiding this comment.
params 대신 bookId가 좋아보입니다!
publdaze
reviewed
Jan 18, 2024
src/api/libraryManageApi.ts
Outdated
| borrowLogList: (param: BorrowLogListSearch) => ['libraryManage', 'borrowLogList', param] as const, | ||
| base: ['manage'] as const, | ||
| book: () => [...libraryManageKeys.base, 'books'] as const, | ||
| borrowInfo: () => [...libraryManageKeys.base, 'borrow-infos'] as const, |
There was a problem hiding this comment.
아마 카멜케이스로 하기로 했던 것 같습니다!
borrow-infos -> borrowInfos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
작업 요약
�Library Manage Api 쿼리키 포멧 통일
작업 상세 설명
리뷰 요구사항
3분