fix(KUI-1136): remove kursinfo-api dependency to this repository #386
Conversation
There was a problem hiding this comment.
I notice that we have a MEMO_STORAGE_URI in prod.parameters.json, but not in ref.parameters.json.
I'm wondering right now - how does this actually work in REF? Because PDFs work in ref, but how? Where do we get the correct link from? Do we run the app in REF with the dev or development environment set in node?
There was a problem hiding this comment.
I guess, the correct fast way would be to add the parameter in ref.parameters as well (obviously the one pointing to REF)
There was a problem hiding this comment.
That was a really good point, it was my question as well. So inside commonSetting.js we are setting devMemoStorageUri.
const devMemoStorageUri = 'https://kursinfostoragestage.blob.core.windows.net/memo-blob-container/'
Sure, I have checked the PDFs and they are comming from kursinfostoragestage in the ref environemnt. I will also create a comment in Jira as well. |
I have removed everything related to kursinfo-API in this repository,
I have tested pages like:
kth.se/kurs-pm/HF1201/om-kurs-pm
https://app-r.referens.sys.kth.se/kurs-pm/SF1624/SF162420252-40001
on my local environment to be sure that the changes have not had any kind of side effect.
In my tests I focused on PDFs comming from kursinfostoragestage and PDFs that will be created for kurs-pm and the general functionalities.