Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUI-1164 style fixes #262

Merged
merged 3 commits into from
Jan 2, 2024
Merged

KUI-1164 style fixes #262

merged 3 commits into from
Jan 2, 2024

Conversation

belanglos
Copy link
Contributor

This PR includes

  • fixes for style issues after kth-style upgrade
  • introduction of fake timers in a test to eliminate the need of updating snapshots every year
  • eslint fixes

@belanglos
fix(KUI-1164): CSS fixes after style upgrade
968faf6
@belanglos
fix(test): set fake system time in test
0a9673f 
We use a snapshot test in StatisticsForm(EN|SV).test.js. The dropdown options are based on the current time.
Previously we had to update the snapshots every year, now the system time is fixed to march 2023, so updating the snapshots is not necessary anymore.
@belanglos
ref(test): satisfy eslint
be528ef
@belanglos belanglos requested a review from vsdkth January 2, 2024 10:32
vsdkth
vsdkth approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@vsdkth vsdkth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut!

@belanglos belanglos merged commit fafd56e into master Jan 2, 2024
3 checks passed
@belanglos belanglos deleted the issues/KUI-1164-style-fixes branch January 22, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsdkth vsdkth vsdkth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@belanglos @vsdkth