Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/k UI 1136/kurs alert #272

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Feat/k UI 1136/kurs alert #272

merged 8 commits into from
Jan 31, 2024

Conversation

vsdkth
Copy link
Contributor

@vsdkth vsdkth commented Jan 29, 2024

No description provided.

@vsdkth vsdkth requested a review from belanglos January 29, 2024 13:25
belanglos
belanglos requested changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@belanglos belanglos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Please have a look at whether the test pipeline failed because wrong tests or wrong code or pipeline hiccup. :)

@vsdkth vsdkth requested a review from belanglos January 31, 2024 09:10
belanglos
belanglos approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@belanglos belanglos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: question, if I understand correctly, the last commit will also prevent problems in ref/prod, not only the test suite. Right?

@vsdkth vsdkth merged commit 8da7ceb into master Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belanglos belanglos belanglos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsdkth @belanglos